commit 5bc52c76c2816a3be9a033c3e5bf4fea1908e3cd Author: Paul Jakma Date: Mon Jun 22 16:11:06 2009 +0100 [doc] remove -dither arg to imagemagick, in building PDFs * doc/Makefile.am: arguments for the 'convert' programme seem to have changed incompatibly at some stage - just remove the problematic -dither. commit 86f72dcba35f055b5344deeb5f057c2f1d9a291f Author: Takashi Sogabe Date: Mon Jun 22 13:07:02 2009 +0900 Convert ospf6d over to quagga_gettime() wrappers. commit f7e0db80693aea7f5fd3d8d4f00e97347c8d0ba5 Author: Paul Jakma Date: Mon Jun 22 11:30:47 2009 +0100 [bgpd] Fix 'update-source' command: It doesn't accept interface names * bgp_vty.c: BGP_UPDATE_SOURCE_STR define should only specify IP addresses, the underlying mechanisms won't do anything useful with interface names. Fix bug #527. commit c514adc61d56c3fb6fe5119a7b4b55c79a9c065d Author: Jeremy Jackson Date: Fri Jan 23 15:48:10 2009 -0500 [ospfd/BSD] add missing UINT16_MAX - picked up from FreeBSD ports patch Should probably have AC_TYPE_UINT16_T in configure.ac to make it really clean... and a fresh import of gnulib, the existing copy of gnulib seems to be manually put some stuff in zebra.h. I'm leaving that alone for now, since a fresh import will probably clean up a lot of cruft and it would be a duplicated effort to fix some things now. The FreeBSD port 0.99.11_1 files/patch-ospfd-ospfd.h can probably go away after this is applied. commit 7ec573661ff046f6fa97d694de7a68dede2532fd Author: Jeremy Jackson Date: Wed Jan 21 22:10:40 2009 -0500 [configure] fix check for GNU awk/gawk to abort ./configure if missing It also prints what were comments explaining why gawk is necessary, and not-in-PATH to help user figure out why it's not found. Build was mysteriously failing with the old version of this check when gawk wasn't installed. commit ec5e42b3c50e3a8e95963161319fa1a56466b2ae Author: Jeremy Jackson Date: Wed Jan 21 20:51:57 2009 -0500 [cleanup] convert bzero() deprecated by POSIX to memset() autoscan 2.62 complains about bzero(), so a good fix nowadays is to just replace it. commit e84999d93afd0f727f7325431c055cc26c988c68 Author: Jeremy Jackson Date: Wed Jan 21 20:29:39 2009 -0500 [configure] remove unused/broken autoconf cache variable ac_statedir It wasn't used, and the code wasn't printing progress or the result in some cases. the test uses minimal resources, so it's probably better to not cache so as to avoid inconsistencies if --with-prefix or directory variables are changed between ./configure runs. commit 5589ffa7dd6846a83e1d312f3dc3f2aa47e40f92 Author: Jeremy Jackson Date: Wed Jan 21 18:27:37 2009 -0500 [configure/cleanup] fix broken autoconf cache variables Fix zebra_rtread and zebra_ipforward_path. It looks like someone tried to make this cached, but it was being ignored at least on autoconf 2.6.1. 2.6.2 now gives a warning about the situation, hence this fix. Although they are just warnings, it's dangerous to leave them as-is, because someone not diligent in reading the autoconf manual might just stick _cv_ in the name, with the effect that running a ./configure --config-cache would fail horribly, since variables are being set inside the AC_CACHE_CHECK() block that would not be seen when the variable's value was read from cache. Also added m4 quotes [] to macro arguments as autoconf manual suggests. commit 7f177ee8df0437ba0d002c1226201150639dcd09 Author: Jeremy Jackson Date: Wed Jan 21 16:35:51 2009 -0500 [configure] remote support for AIX, it conflicts on newer autoconf AC_AIX and AC_GNU_SOURCE conflict > autoconf 2.53 or so, but the replacement AC_USE_SYSTEM_EXTENSIONS isn't available until later versions. So either we narrow the supported autconf version range, or disable AIX (if it has any effect), or determin that AC_AIX doesn't do anything useful anyhow. commit 4bf6461e0f6cc6dcb8ca54314bc6c1865a366e70 Author: Jeremy Jackson Date: Wed Jan 21 14:15:44 2009 -0500 [build] cleanup low-hanging autoreconf warnings Some uses of GNU make extensions were not necessary. There are still some, but they might exist as workarounds for older versions of autoconf that have since been solved. Lesson learned: implicit target rules have opposite order to pattern target rules. commit 25f45887abf320401745dd433c4e82bfd6db5d4d Author: Jeremy Jackson Date: Mon Jan 12 16:06:12 2009 -0500 [configure] add configure support for PCRE Posix library Debian tried unsuccessfully to build with libpcreposix. This adds proper support to autoconf/configure.ac for it. Based on the patch by C.J. Adams-Collier in bug #483. bgpd/bgp_{regex,routemap}.h: Pull in PCRE POSIX header if available. commit c77cffdd69bf08ed54e390a3485cbd5024836a9a Author: Jeremy Jackson Date: Sun Dec 28 12:57:42 2008 -0500 [daemons/cleanup] Remove disabled log_mode argument support. * */*main.c: Seems that the actual code was removed previously, but the argument processing code remained. commit c546afaed229106c2fcb54b57906414b9503dcc9 Author: Jeremy Jackson Date: Sun Dec 28 12:40:06 2008 -0500 [doc] Removes documentation of nonexistant option. Expansion of Ubuntu quagga-0.99.11-1 30_doc__ospfd.8__nolog.dpatch commit 6511cab26728453d1b5e572bbbc3775f70c10c0e Author: Paul Jakma Date: Thu Jun 18 17:38:01 2009 +0100 [configure] Refine CLOCK_MONOTONIC test * configure.ac: Check for the actual CLOCK_MONOTONIC symbol, as clock_gettime need not imply that clock type is supported * lib/zebra.h: use the method given in autoconf docs for sys/time.h inclusion commit c4376c9d28f1282f502ed5279ee80ec5c4cb810d Author: Stephen Hemminger Date: Thu May 28 15:29:10 2009 -0700 [configure] Detect support for monotonic clock Quagga has code to support monotonic clock to avoid issues where time of day changes. The support was incomplete since it was not being detected by autoconf. commit 8f5abac1c3f5ad18561cad560bd42b50d2419d94 Author: Stephen Hemminger Date: Fri May 15 10:16:34 2009 -0700 [BGP/cleanup] make message list in bgp_open const commit 730394d9a33dceb0699c5268afd1049aa225c5c7 Author: Stephen Hemminger Date: Fri May 15 10:17:09 2009 -0700 [BGP/cleanup] make community hash table static commit e9dc9f247a668ece1b983cc964fec852c737bedd Author: Stephen Hemminger Date: Fri May 15 10:19:31 2009 -0700 [BGP/cleanup] make some damp function static commit ffa4e2c4712ddcb5085971aaf001f030723ee307 Author: Stephen Hemminger Date: Fri May 15 10:28:11 2009 -0700 [BGP/cleanup] make ecommunity variables/functions local commit 372b3c70a090359fe401dbb5e7c34ff8ae09f757 Author: Stephen Hemminger Date: Fri May 15 10:29:41 2009 -0700 [BGP/cleanup] main program cleanup Check result of daemon() call to fix warning Make local variables static commit ce0db9cb11c0bc2e7f89a7d042e50afa495556b4 Author: Stephen Hemminger Date: Fri May 15 10:47:04 2009 -0700 [zebra/cleanup] make message table read only commit 7ba82f70ddf9abf99277b25cd54503a8517a0c15 Author: Stephen Hemminger Date: Fri May 15 10:47:45 2009 -0700 [OSPF/cleanup] make message lists read only commit b2d933f8280a4d9eee8a9330282e705514a96a03 Author: Stephen Hemminger Date: Fri May 15 10:48:03 2009 -0700 [bgpd/cleanup] make message lists read only commit 01b7ce2db345429d7abc0446840f1d5c303c80af Author: Paul Jakma Date: Thu Jun 18 12:34:43 2009 +0100 [bgpd] add comment that bgp_capability_receive is exported for unit-tests commit 8e4c09307d9eafbbbf7fbffb3d3483287cea169b Author: Stephen Hemminger Date: Fri May 15 09:47:34 2009 -0700 [cleanup] Allow message tables to be constant Avoid bugs, and improve cache locality by allowing message lists to be read/only. commit fc52f95373b1dc0bec5f5a474bafa362b02a63ae Author: Stephen Hemminger Date: Fri May 15 09:48:55 2009 -0700 [cleanup] Fix compile warnings Fix printf format warning and make capability table 'const static' commit 65d3fbb4835e268b1683b88b12e101c6592b1948 Author: Stephen Hemminger Date: Fri May 15 09:59:03 2009 -0700 [cleanup] Use const in smux interface smux_trap and oid_copy should allow read-only source. commit 9bddac4bd50034c713940ad77cebfbb7f3cd123a Author: Stephen Hemminger Date: Fri May 15 09:59:51 2009 -0700 [bgpd/cleanup] BGP make attribute variables local Message lists can be read-only, and hash tables are local to this code. commit fda1d3e033f98c7e34ccdaead27e8df39af12a85 Author: Stephen Hemminger Date: Fri May 15 10:02:27 2009 -0700 [bgpd/cleanup] Make BGP FSM table read-only static The finite state machine table is immutable. commit 0088b5dc55a91d27e572484e61df71b8ca2eddf4 Author: Stephen Hemminger Date: Thu May 21 08:51:03 2009 -0700 [bgpd] reference count the BGP instance When a BGP instance is deleted with lots of routes and neighbors it is possible for the peer rsclient queue to run after bgp_delete has been called. This would lead to bgpd crashing, see https://bugzilla.vyatta.com/show_bug.cgi?id=3436 The fix is to add reference counting to the BGP instance and defer actual freeing until all references are gone. This patch also fixes a memory leak where the self-reference peer instance was being created but never freed. The check in bgp_clear_route is no longer valid because it is possible for it to be called when peer is in Deleted state during cleanup. commit dde7258666fd73878b4cc10b4b5b7c07e9be049e Author: Stephen Hemminger Date: Fri May 8 15:19:07 2009 -0700 [bgpd] Make declarations match These variables are const. commit 9607d98cb04e5dff34cb2f6fb6434455c6841ab8 Author: Stephen Hemminger Date: Wed Apr 29 21:55:48 2009 -0700 [zebra] Remove unused structure element commit 90d2ab0f9426d670552b929364f8fb7de122efe5 Author: Stephen Hemminger Date: Wed Apr 29 21:54:59 2009 -0700 [zebra] Force rib_update when connected route deleted commit 81cce0185e23b6ecd2ab98ab34182901226bcf9e Author: Stephen Hemminger Date: Tue Apr 28 14:28:00 2009 -0700 [cleanup] Use correct buffer size for inet_ntop() Don't need big buffer 1024 to hold IPV4 (INET_ADDRSTRLEN) or IPv6 (INET6_ADDRSTRLEN) message. commit 82f5ee1ead0aa83f83f918abfc3f5071741a56e5 Author: Stephen Hemminger Date: Tue Apr 7 15:00:46 2009 -0700 [ripd] Ignore non-running interfaces in rip status Vyatta Bug 3999 commit 94fc1dd41cd0267acb9c67dd3dcf1e64ef8713af Author: Stephen Hemminger Date: Mon Mar 9 16:09:50 2009 -0700 [lib] Put symbolic backtrace on system log When BGP crashes, sometimes all we get to see is syslog. commit e5862a2df2b5f65b0c050987c5f145836e0b75b3 Author: Stephen Hemminger Date: Thu Feb 19 23:01:41 2009 -0800 [lib] sockopt_tcp_signature: sin6 requires HAVE_IPV6 An external user was building on system without IPv6 and it wouldn't work. commit 66a11e76d4a8ee18c4e79c06d25814b9aa94e45d Author: Stephen Hemminger Date: Wed Feb 11 23:55:32 2009 -0800 [ospf6d] Remove 'no router' from OSPF6_NODE Don't need command twice. commit 56abbb886f6ad8dce9dd7d336d010861ca9dd2b9 Author: Jon Date: Wed Feb 11 17:30:44 2009 -0800 [ospf6d] Fix ospf6d crash if removing interface with no area ospf6d will crash if attempting to remove interface when no areas have been defined Check if any areas have been defined. Should prevent use of empty pointer. commit 597fa7c185e34aac7bc1df22263e9414bccd9a9f Author: Jon Date: Wed Feb 11 17:27:06 2009 -0800 [ospf6d] Fix ospf6d crash in show border routers ospf6d will crash if this command is executed on a non-border-router. Included test to verify that any routes are defined, preventing empty pointer from being used. commit 6c19d26a019da198ea7e181731b8eb9553725f2d Author: Jon Date: Wed Feb 11 17:19:07 2009 -0800 [ospf6] Add no router ospf6 Suggestion: Makes no sense to me that the statement to remove ospf6 configuration is located in OSPF6D_NODE. Moved to CONFIG_NODE next to matching define command. commit 86f9e5a7f3a80d6df13a9750d2148693daa14c8d Author: Jon Date: Wed Feb 11 17:22:03 2009 -0800 [ospf6d] Fix ospf6d crash if range defined twice ospf6d will crash if the same range is defined twice. There was no check if the same range had previously been defined, thereby causing a later assert to fail. commit 965f54f5ef0bd601cf129bd4b964863251313ec9 Author: Stephen Hemminger Date: Wed Jun 3 16:44:21 2009 -0700 [ospfd] Fix OSPF route refcount leak This may fix vyatta BUG 3096. The reference count for OSPF route table was never completely freed on deleting all neighbors. commit fd21325b2eb252644bc70918ace4f9c6c00c45ef Author: Stephen Hemminger Date: Sat Jul 5 16:32:37 2008 -0700 [zebra] Only announce connected routes if link is detected Need to check both IFF_UP and IFF_RUNNING if link-detect is enabled, before announcing routes. commit 4308abba5cab18c1d30b962567b06b02a1a15361 Author: Stephen Hemminger Date: Mon Dec 1 14:19:38 2008 -0800 [zebra] MTU is unsigned The MTU data in the netlink message is always unsigned 32 bits. Don't use integer. commit 6c684653f08fadf738ca52a3fbe512e3d1698ceb Author: Stephen Hemminger Date: Thu Sep 18 16:51:06 2008 -0700 [zebra] remove incorrect debug message commit 5110a0c6222be91d3b2a786692949dd94fb0c9ac Author: Stephen Hemminger Date: Mon Aug 11 16:22:15 2008 -0700 [zebra] Cleanup meta-queue code Do some cleanup work on recently added meta-queue code: * use table rather than switch * indent with quagga standard indentation * since meta_queue_new is only used at initialization allocation failure should be fatal. commit c84154977d822ceee9df66be535c56cb5f0fce10 Author: Stephen Hemminger Date: Wed May 28 10:47:30 2008 -0700 [zebra] netlink interface minor cleanup Add more prototypes and make some functions static commit 61691c91c15445445b0ac246ee12e559a4cacdb5 Author: Stig Thormodsrud Date: Tue Nov 4 15:45:07 2008 -0800 [zebra] Fix vyatta bug 2814: Add "show ip route summary" command. commit 914131f80da7b9696d26b42ed92b2d93d4d8b3ab Author: Stephen Hemminger Date: Wed Jul 30 14:16:47 2008 -0700 [vtysh] Add a --noerror option There are times that configuration scripts want to run vtysh but don't want to get error messages or failed exit status commit 2c4d48bc018c5bdca6faa953fbf6ff828becbc45 Author: Stephen Hemminger Date: Mon Jul 28 15:04:56 2008 -0700 [vtysh] Return non-zero exit code on error. If passed a bad command, return non-zero exit code commit 57fb974856b9ae143ca5642e279d181a45bbdd10 Author: Stephen Hemminger Date: Mon Jul 28 12:19:04 2008 -0700 [vtysh] Make vtysh more useable for scripting Add environment variable (VTYSH_LOG) for logging. If a command fails, exit with non-zero exit code and don't continue multipart commands. commit 0fbd62a17c53f1e2695c0f96ffb437cd079abacb Author: Stephen Hemminger Date: Fri May 2 09:25:02 2008 -0700 [vtysh] Force line buffered mode. Vtysh is used in pipelines and it helps if the output starts right away instead of waiting for a whole buffer to fill. commit 80c375e72d7c3b9fe41b1ffec461ec5e1b57caa7 Author: Stephen Hemminger Date: Fri Aug 8 15:15:23 2008 -0700 [gcc] Add gcc printf format checks commit 7fc626de5f618133ad2a478d13defa3a110b89ea Author: Stephen Hemminger Date: Mon Dec 1 11:10:34 2008 -0800 [cleanup] Make command nodes static The cmd_nodes used to configure vty, can mostly be static so (basic data hiding 101). commit 66e5cd87194ae6fdd51061a91b4698bc0a652f6b Author: Stephen Hemminger Date: Mon Feb 9 10:14:16 2009 -0800 [cleanup] functions taking no args should be declared with void args Use Ansi-C prototypes rather than old K&R method of declaring function without arguments commit cedd7f2fa6823bca9ddcfb062f97ed83b11a80dd Author: Stephen Hemminger Date: Fri Jun 12 16:58:49 2009 +0100 [cleanup] add const attribute to lib/if.c::if_dump commit 393deb9bd663361e6b110d579a8b1d4c22667068 Author: Stephen Hemminger Date: Mon Aug 18 14:13:29 2008 -0700 [cleanup] Convert XMALLOC/memset to XCALLOC Simple conversion of XMALLOC/memset to XCALLOC commit 3453a7122c1d585ad789ed0f63deb90cc5e89fae Author: Paul Jakma Date: Fri Jun 12 14:21:02 2009 +0100 [bgpd] Add support for the old Linux 2.4, TCP_MD5_AUTH RFC2385 patch * configure.ac: Add a --enable-linux24-tcp-md5 argument, to compile in support for the old TCP-MD5 patch for Linux 2.4 systems. This overrides auto-detection of TCP-MD5 supported by the target system. * lib/sockopt.c: (sockopt_tcp_signature) add in a variant for the old Linux 2.4, TCP_MD5_AUTH variant of TCP-MD5 support, conditional on the previous configure arg. commit 10819ecee3ced786162b68310cf172aacda18857 Author: Denis Ovsienko Date: Tue Jun 9 15:15:33 2009 +0400 [bgpd] Fixed as-path prepend/exclude ASN handling - aspath_gettoken(): use as_t to fix 4-byte ASN scanning (bug #484) - set_aspath_prepend_cmd(): use CMD_AS_RANGE in message to match actual range - no_set_aspath_prepend_val_cmd(): idem - set_aspath_exclude_cmd(): idem - no_set_aspath_exclude_val_cmd(): idem commit 0be8dfb2a95f41f100982085595b7c7505127018 Author: Chris Caputo Date: Tue Jun 2 18:40:07 2009 +0100 [snmp] Compiler warning fixes for when "--enable-snmp" is configured. Compiled on 32-bit and 64-bit linux gcc 4.1.2 platforms. No run-time testing on 32-bit and limited run-time testing on 64-bit. commit 42176e6b01c9ca2b2725952684b2d7792468e861 Author: Chris Caputo Date: Tue Jun 2 18:37:11 2009 +0100 [smux] 64-bit fix for lib/smux.h SNMP_INTEGER() macro Macro SNMP_INTEGER() prepares data which is eventually processed by asn_build_int(). SNMP_INTEGER() was using "int32_t" whereas asn_build_int() uses "long". On 32-bit systems these are the same, both 4 bytes, but on x86 64-bit systems "long" is 8 bytes. asn_build_int()'s reaction to an improperly sized value is to return a NULL pointer. Quagga's smux.c would eventually get this NULL pointer and use it in calculations to determine how much data to send over the smux connection, resulting in garbage being sent to the SNMP agent. Corrected SNMP_INTEGER() to use "long". Tested on 32-bit and 64-bit x86 Linux 2.6.27.10 systems running Quagga 0.99.11 with bgpd smux. commit 04d23314ddf950fefb3ff18306c7564bf4573a12 Author: Francesco Dolcini Date: Tue Jun 2 18:20:09 2009 +0100 [ospfd] fix vty ospfd no ospf abr-type standard "no ospf abr-type standard" was broken commit c5a89ff4e68c49b8841baf3c76290dd78ba383ec Author: Krisztian Kovacs Date: Tue Jun 2 18:09:48 2009 +0100 [ripd] Fix metrix in call to rip_zebra_ipv4_delete Fix a potential problem (most probably not triggering a real problem, at least on Linux). When an interface goes down and ripd tries to delete the corresponding route it errorneously passes the interface's index instead of the metric to zebra. commit acde4b861333d799b50d6e8a53214abc0d17ede3 Author: Steve Hill Date: Tue Jun 2 14:28:16 2009 +0100 [bgp] Fix crash on SIGHUP, deref of freed workqueues * lib/workqueue.c: free-ing workqueues had never been tested obviously, queue's thread was not being stopped * bgpd/bgpd.c: null out freed workqueues, to prevent acting on freed workqueues commit e6b6a56419ed5a2e8cf2cb11eab340d7b0d28055 Author: Denis Ovsienko Date: Mon Jun 1 20:20:36 2009 +0400 [trivia] Fixed typos in communities text (#334) commit 2bbd71aace61a70a631c1d0c0bce75fbc76ee1d1 Author: Denis Ovsienko Date: Mon Jun 1 20:07:46 2009 +0400 [doc] Stick with quagga.net for consistency (#436) commit 8178b2e156d2263015d7d981590a0899f2cb4c05 Author: Andrew J. Schorr Date: Fri May 29 09:15:20 2009 -0400 [bgpd] 64-bit bugfix in community_del_val by Jeremy Jackson * bgpd/bgp_community.c: (community_del_val) Fix bug in memcpy that was using the wrong size on architectures where a pointer is not 32 bits.